Skip to content

GitLab

Merged
Created by edsmall@edsmallContributor

ARGODEV-169: refactor region data

Jira Issue

ARGODEV-169 (https://jira.ceh.ac.uk/browse/ARGODEV-169

Python Implementation

Move the similar code into their own functions and files so that they can be called by both retr_region and get_region

Testing

Two functions were created here, so we have two new test cases:

get_data

  • Test that we retrieve no data if we don't specify where we want the data from
  • Test that we retrieve the correct amount of data
  • Test that if the argo float currently being analysed appears in the data we are retrieving then it is removed
  • Test that the shape of each data array returned is comparatively the same

wrap_longitude

  • Test that we don't wrap values when it is not needed
  • Test that wrapped values give the expected output
  • Test that we don't lost any longitude values

Old Matlab Implementation

Had some code that had clearly been copied and pasted between get_region and retr_region. One part of the code retrieved data from some bottle/ctd/argo files, the other manipulated longitude values to ensure maps looked correct.