Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
owc-software-python owc-software-python
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bodc
  • owc-software-pythonowc-software-python
  • Merge requests
  • !27

Merged
Created May 12, 2020 by edsmall@edsmallContributor

Bug fix: NaN data

  • Overview 0
  • Commits 7
  • Pipelines 4
  • Changes 2

Jira Issue

None, tracked in guthub: https://github.com/euroargodev/User-Acceptance-Test-Python-version-of-the-OWC-tool/issues/2

Python Implementation

When we have found our best historical data, check that the salinity and pressure associated with the climatology has at least some data. If no data is present, we delete this column.

Testing

Check that a nan column is removed from the data set

Old Matlab Implementation

Matlab simply returns 1 if it cannot find the minimum of a matrix, so whilst we can use the matlab data in the matlab version, this behaviour is not predictable and is undefined, so removing the bad data is a better option

Edited May 12, 2020 by edsmall
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: edsmall/nan-data