GitLab

Closes #1 (closed)

changed milestone to %SoAR-2023W01

added Partner::NOC Status::In Progress Weight::1 labels

added 1 commit

• 8f44e4b3 - feat: prototype adapter from example-web-client

Compare with previous version

added 1 commit

• 2e6093c4 - fix: pass config to adapter constructor

Compare with previous version

added 1 commit

• e0d98aae - refactor: move src and build dist files

Compare with previous version

added 1 commit

• 3a67cd1d - fix: run build on install

Compare with previous version

added 1 commit

• 1fecff3c - refactor: use constructor config in adapter auth

Compare with previous version

added 1 commit

• 038f003d - fix: correct syntax error in urls

Compare with previous version

added 1 commit

• 33f25858 - fix: rebuild dist files

Compare with previous version

added 1 commit

• 20f10b52 - fix: correct use of this in wrong context

Compare with previous version

added 1 commit

• 7dfb8ec8 - fix: check presence of config

Compare with previous version

added 1 commit

• 978de303 - debug: remove debug error logging

Compare with previous version

marked this merge request as ready

This is working. I'll update the branch of the exmaple-web-client so that uses it.

For now I've committed the dist files. If we were to push to npm we could do the build on the npm publish. I've not found a good way yet of building the dist files dynamically post install.

There's no tests yet but that's my next ticket.

added 1 commit

• ec074c62 - fix: add missing axios dependency

Compare with previous version

requested review from @trishna

added 17 commits

• 43b2b99f - test: initial setup of cucumber
• 10d87d6d - test: initial tests of authentication
• 716ec0de - test: add tests for auth method
• 8b0e7ce8 - test: add tests for receive method
• 1ff6f48a - test: test validate method
• b3e0ef86 - test: add poll and publish tests
• bb722d6b - test: add tests for adapter broadcast method
• 73605335 - test: add tests for token handling
• 73db2678 - test: add coverage for protocol methods
• ba07f203 - test: move axios to dev dependencies
• 7efb283a - docs: explain axios dependency in README
• be220d3f - test: update example messages to match new schema
• b5ff7390 - docs: include local setup and test in readme
• a212a58d - docs: move dependencies in readme
• c4d324c2 - fix: add required actions property to mission
• 645b90f6 - refactor: move common steps from auth into common
• 03de0f57 - Merge branch '3-implement-bdd-tests-in-cucumber' into...

Compare with previous version

Would it make sense to add the message protocol (backbone-message-formats) as a submodule?

added Status::In Review label and removed Status::In Progress label

added 2 commits

• dc9e90b9 - fix: correct comment typo
• eb7cb068 - docs: add comments and examples

Compare with previous version

I'll leave final approval for @trishna but all LGTM

All's good once the new issues are created where needed.

resolved all threads

approved this merge request

merged

mentioned in commit c1fcc17c