fix: correct error code resp (!17) · Merge requests · Communications Backbone System / communications-backbone · GitLab

fix: correct error code resp

1 unresolved thread

closes: #34 (closed) #32 (closed)

Edited 2 years ago by James Kirk

James Kirk @jamki marked this merge request as draft 2 years ago

marked this merge request as draft
James Kirk @jamki added 1 commit 2 years ago
added 1 commit

9f6bfd59 - refactor: linting

Compare with previous version
James Kirk @jamki marked this merge request as ready 2 years ago

marked this merge request as ready
Trishna Saeharaseelan @trishna · 2 years ago

Owner

Resolved by Trishna Saeharaseelan 2 years ago

Looks good! Small comment: might be a thought to update the rest of the exception error messages for the other endpoints to use werkzeug exceptions for consistency.

Last reply by Trishna Saeharaseelan 2 years ago
Trishna Saeharaseelan @trishna approved this merge request 2 years ago

approved this merge request
Trishna Saeharaseelan @trishna changed milestone to %SoAR-2023W09 2 years ago

changed milestone to %SoAR-2023W09
Trishna Saeharaseelan @trishna added Partner::NOC Status::In Review labels 2 years ago

added Partner::NOC Status::In Review labels

Dan Jones @danjon started a thread on an old version of the diff 2 years ago

Last updated by James Kirk 2 years ago

endpoints/client.py

         return client, 204
     def put(self, client_id):
         args = request.get_json()
         try:
             args = request.get_json()
         except BadRequest:
             return "POSTed body is invalid JSON", 400

James Kirk @jamki added 1 commit 2 years ago
added 1 commit

0a48aa56 - refactor: returns into aborts

Compare with previous version
Dan Jones @danjon approved this merge request 2 years ago

approved this merge request
James Kirk @jamki merged 2 years ago

merged
James Kirk @jamki mentioned in commit c6a34801 2 years ago

mentioned in commit c6a34801
You're only seeing other activity in the feed. To add a comment, switch to one of the following options.

Please register or sign in to reply