Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
communications-backbone communications-backbone
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Communications Backbone System
  • communications-backbonecommunications-backbone
  • Merge requests
  • !17

Merged
Created 2 years ago by James Kirk@jamkiOwner

fix: correct error code resp

  • Overview 3
  • Commits 3
  • Pipelines 3
  • Changes 3
1 unresolved thread

closes: #34 (closed) #32 (closed)

Edited 2 years ago by James Kirk
  • James Kirk @jamki marked this merge request as draft 2 years ago

    marked this merge request as draft

  • James Kirk @jamki added 1 commit 2 years ago

    added 1 commit

    • 9f6bfd59 - refactor: linting

    Compare with previous version

  • James Kirk @jamki marked this merge request as ready 2 years ago

    marked this merge request as ready

    • Trishna Saeharaseelan
      Trishna Saeharaseelan @trishna · 2 years ago
      Owner
      Resolved by Trishna Saeharaseelan 2 years ago

      Looks good! Small comment: might be a thought to update the rest of the exception error messages for the other endpoints to use werkzeug exceptions for consistency.

    • Trishna Saeharaseelan
      Last reply by Trishna Saeharaseelan 2 years ago
  • Trishna Saeharaseelan @trishna approved this merge request 2 years ago

    approved this merge request

  • Trishna Saeharaseelan @trishna changed milestone to %SoAR-2023W09 2 years ago

    changed milestone to %SoAR-2023W09

  • Trishna Saeharaseelan @trishna added Partner::NOC Status::In Review labels 2 years ago

    added Partner::NOC Status::In Review labels

  • Dan Jones
    Dan Jones @danjon started a thread on an old version of the diff 2 years ago
    Last updated by James Kirk 2 years ago
    endpoints/client.py
    37 40 return client, 204
    38 41
    39 42 def put(self, client_id):
    40 args = request.get_json()
    43 try:
    44 args = request.get_json()
    45 except BadRequest:
    46 return "POSTed body is invalid JSON", 400
    • Dan Jones
      Dan Jones @danjon · 2 years ago
      Owner

      This should be an abort like the validation errors.

    • James Kirk @jamki changed this line in version 3 of the diff 2 years ago

      changed this line in version 3 of the diff

    • Please register or sign in to reply
  • James Kirk @jamki added 1 commit 2 years ago

    added 1 commit

    • 0a48aa56 - refactor: returns into aborts

    Compare with previous version

  • Dan Jones @danjon approved this merge request 2 years ago

    approved this merge request

  • James Kirk @jamki merged 2 years ago

    merged

  • James Kirk @jamki mentioned in commit c6a34801 2 years ago

    mentioned in commit c6a34801

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
Compare
  • version 2
    9f6bfd59
    2 years ago

  • version 1
    42c71fa8
    2 years ago

  • dev (base)

and
  • latest version
    0a48aa56
    3 commits, 2 years ago

  • version 2
    9f6bfd59
    2 commits, 2 years ago

  • version 1
    42c71fa8
    1 commit, 2 years ago

1 file
+ 1
- 0
Show latest version
    File browser
    Compare changes
endpoints/client.py
+ 1
- 0
  • View file @ 9f6bfd59

  • Edit in single-file editor

  • Edit in Web IDE


Files with large changes are collapsed by default.

Show all unchanged lines Show 20 lines
logging.basicConfig(level=logging.INFO)
logging.getLogger("pika").setLevel(logging.ERROR)
class ClientSchema(Schema):
client_id = fields.Str(required=True)
client_name = fields.Str(required=True)
Show 20 lines Show all unchanged lines
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
SoAR-2023W09
Milestone
SoAR-2023W09 (Past due)
Assign milestone
None
Time tracking
No estimate or time spent
2
Labels
Partner::NOC Status::In Review
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
3
3 participants
user avatar
user avatar
user avatar
Reference: communications-backbone-system/communications-backbone!17
Source branch: improved-errors

    0 pending comments