GitLab

added 9 commits

419d39d1...61d88a37 - 7 commits from branch dev
7005d0be - feat: added in gitlab-ci, seeing if just pointing to ci-scripts works
23ed1d65 - Merge branch 'gitlab-ci' of...

Compare with previous version

added 10 commits

23ed1d65...e247a1a5 - 9 commits from branch dev
813d3b0e - feat: added in gitlab-ci, seeing if just pointing to ci-scripts works

Compare with previous version

added 1 commit

4b284540 - refactor: removed __init__ from root as it causes import issues in a container

Compare with previous version

added 1 commit

ffb56980 - fix: added in TEST_DOCKER_COMPOSE var

Compare with previous version

added 1 commit

7bb2668f - fix: updating run-compose to match ci-scripts stage

Compare with previous version

added 1 commit

57a89c55 - refactor: cleaned up pipfiles

Compare with previous version

added 1 commit

7764747b - refactor: stopping pytest caching

Compare with previous version

added 1 commit

701eb771 - refactor: only prevent cache when testing

Compare with previous version

added 1 commit

ba48921b - fix: forgot to export var

Compare with previous version

added 1 commit

f6501eca - fix: passing in env var in yaml

Compare with previous version

marked this merge request as ready

added 1 commit

db23a5af - refactor: adding a dev/prod alternative so the released image is shippable

Compare with previous version

After pulling it back down and running the container:

kirk@NOCS05411V:~/repos/communications-backbone$ docker ps
CONTAINER ID   IMAGE                                                     COMMAND            CREATED          STATUS          PORTS     NAMES
a7b456a56568   registry.c2.noc.ac.uk/communications-backbone:gitlab-ci   "sleep infinity"   44 seconds ago   Up 43 seconds             cranky_swartz
kirk@NOCS05411V:~/repos/communications-backbone$ docker exec -it cranky_swartz /bin/bash
root@a7b456a56568:/app# ls
LICENSE    api.py          client_send.py  docker     models          requirements-dev.txt  rmq.py          soar_bus.py
README.md  client_read.py  conftest.py     endpoints  old_mq_wrapper  requirements.txt      run-compose.sh  tests
root@a7b456a56568:/app#

changed milestone to %SoAR-2023W05

Looks good. Just wanted to ask:

Any reason the __init__.py file was deleted?
Since the Pipfile is deleted, would you mind updating the README.md to remove the Pipfile instruction?

assigned to @jamki

requested review from @trishna

approved this merge request

resolved all threads

merged

mentioned in commit 57b20daa

mentioned in merge request backbone-message-format!4 (merged)

Gitlab-ci