GitLab

If max_depth is set to inf, and two (or more) Records have the same lon and lat, they cannot be split and will infinitely be assigned to the child_left node. max_depth = inf is the standard form for a KDTree as each leaf should have only a single Record.

The previous approach of splitting the array in the middle would not lead to an infinite loop, however it this means that the child_left and child_right nodes can have Records with the same variable value. This could impact performance when querying, and make it more difficult to delete Records from the Tree.

added BUG label

This problem would also arise for the following example:

lons = [1, 2, 4, 4, 4]

Since the median value is 4, the partition would be detected to be at the end, so all points would go to child_left and none to child_right.

created merge request !5 (merged) to address this issue

mentioned in merge request !5 (merged)

mentioned in commit 2fb05223

closed via merge request !5 (merged)