Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
I ICOADS R HOSTACE
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 7
    • Issues 7
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • brivas
  • ICOADS R HOSTACE
  • Merge requests
  • !14

Merged
Created Jun 10, 2020 by brivas@brecinosrivasMaintainer

faster version, subset problem fix

  • Overview 0
  • Commits 6
  • Changes 15

Hello,

Here is the new faster version containing fixes to the following issues:

  1. Issue #4 (closed) : now all functions have the source() paths outside the function {}.

  2. Issue #5 (closed) and #6 (closed): subset() has been replaced with dplyr::filter() in the what is now lines new_merge_ids_year.R#L572 and find_gap_func.R#L50... For more information see issue #5 (closed)

  3. Some of the line numbers from new_merge_ids_year.R and find_gap_func.R have changed since I formatted the code a little bit for an easier reading. I have added some white spaces so when you compare with old version, click the option Hide whitespace changes for an easier comparison.

  4. As requested by liz (@eck), I changed args to my_args to avoid confusion with the R function name args.

The code has been tested for the entire 1970, improving running time from 12.09 hrs to just under 9.48hrs.

New code and new IMMA

Max Memory : 28018 MB Average Memory : 23058.03 MB

Old code and old IMMA

Max Memory : 29121 MB Average Memory : 24346.53 MB

The code has also been tested with the new IMMA Version: 0.0.2 and old version. There are no significant time differences between versions but is possible that this is different for other years.

Also, the data output has been compared between this version and the original tag version from Liz, and all the elements of the data frames compared are equal (MFILES_SHIP_FINAL/1970_1.Rda identical to MFILES_SHIP_FINAL/1970_1.Rda new version) for all the months in that year.

Edited Jun 10, 2020 by brivas
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: docs-updates