Resolve "Add hyphen to regex for version"
looks like it's pyyaml 6.0 as a requirement in the linting bit which is making it fail
Collecting pyyaml==6.0 (from -r requirements.txt (line 22)) Downloading PyYAML-6.0.tar.gz (124 kB) Installing build dependencies: started Installing build dependencies: finished with status 'done' Getting requirements to build wheel: started Getting requirements to build wheel: finished with status 'error' error: subprocess-exited-with-error
Switching the python docker image the CI jobs are using to
python:3.11
might help - if it's a problem with pyyaml 6.0 on python 3.12. Or widen the allowed versions a bit, e.g. in sfmc-adapter I havePyYAML >= 6.0.1, < 7
(I moved the requirements to all be ranges in sfmc-adapter - pinned everything like
package >= current.version.installed, < next_major
-- seems to work nicely)Oh that's one of the things I'd forgotten all about. When I first did this (when NOCS was on fire) I did it with Pipenv and then to make it more like our stuff I turned the Pipfile into a requirements file by just doing
pip freeze > requirements.txt
which ended up putting masses of dependencies in the file that don't need to be there at all.I'd always meant to go back and clean that up. Was hoping we'd have time at the start of this project to do some of those tech-debt,quality-of-life type things but I'd forgotten all about this one.
added 1 commit
- 872fe48f - Revert "chore: comment out unimported dependencies"
added 5 commits
-
872fe48f...c4e76610 - 4 commits from branch
dev
- e33be8cc - fix: add hyphen to regex for schema version
-
872fe48f...c4e76610 - 4 commits from branch
mentioned in commit 80a650d9