Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
backbone-message-format backbone-message-format
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 29
    • Issues 29
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Communications Backbone System
  • backbone-message-formatbackbone-message-format
  • Merge requests
  • !49

Merged
Created 7 months ago by Dan Jones@danjonOwner

Resolve "Update platform status to accommodate simulated wpts"

  • Overview 4
  • Commits 7
  • Pipelines 6
  • Changes 8
All threads resolved

Closes #78 (closed)

Edited 7 months ago by Dan Jones
  • Dan Jones @danjon changed milestone to %CB-2024W37 7 months ago

    changed milestone to %CB-2024W37

  • Dan Jones @danjon added Partner::NOC Project::MAS-DT labels 7 months ago

    added Partner::NOC Project::MAS-DT labels

  • Dan Jones @danjon added 1 commit 7 months ago

    added 1 commit

    • a1880a9e - feat: add waypoint status message for dry-run

    Compare with previous version

  • Dan Jones
    Dan Jones @danjon · 7 months ago
    Owner

    @owanes - done what we discussed yesterday.

    • waypoint_status shares the same format as platform_status so we only need one parser in c2 land
    • waypoint_status requires either waypoint or waypoint_latitude + waypoint_longitude
    • platform_status requires either position or latitude + longitude or no_position_reason which is an enum.

    I'm still a little concerned about the one parser idea because we want to include the current waypoint in the platform_status for ORI but I don't think we want to ingest the waypoint from every platform_status into positions

    Edited by Dan Jones 5 months ago
  • Dan Jones @danjon added 1 commit 7 months ago

    added 1 commit

    • 4c46abdb - refactor: move waypoint_status schema

    Compare with previous version

  • Dan Jones @danjon added 1 commit 7 months ago

    added 1 commit

    • 50ada7fd - refactor: new waypoints message

    Compare with previous version

  • Dan Jones @danjon added 1 commit 7 months ago

    added 1 commit

    • 85aec3d0 - chore: lint with black

    Compare with previous version

  • Dan Jones @danjon marked this merge request as ready 7 months ago

    marked this merge request as ready

  • Dan Jones
    Dan Jones @danjon · 7 months ago
    Owner

    After more talk we've gone back to preferring simulated platform_status for this since during the surface dialog after transferring and re-reading the ma files there should be another real platform_status containing the new waypoint.

    We can use the changes in the platform_status message in this MR for that purpose but we decided to leave the waypoints message in place for now but with no immediate plans to use it.

  • Dan Jones @danjon requested review from @trishna 7 months ago

    requested review from @trishna

  • Trishna Saeharaseelan
    Trishna Saeharaseelan @trishna started a thread on the diff 7 months ago
    Resolved by Trishna Saeharaseelan 7 months ago
  • Dan Jones @danjon added 20 commits 7 months ago

    added 20 commits

    • 85aec3d0...bab76ac7 - 14 commits from branch 67-mas-dt
    • a0ae5a20 - feat: add waypoint status message for dry-run
    • 58f07b32 - refactor: move waypoint_status schema
    • 4a5d19a4 - refactor: new waypoints message
    • f419d7c3 - chore: lint with black
    • c5c9e77e - feat: add enum options for no position
    • 1d51a7b2 - fix: correct uuid for example messages

    Compare with previous version

    Toggle commit list
  • Dan Jones @danjon added 1 commit 7 months ago

    added 1 commit

    • 6901b7d7 - chore: run black

    Compare with previous version

  • Trishna Saeharaseelan @trishna resolved all threads 7 months ago

    resolved all threads

  • Trishna Saeharaseelan @trishna approved this merge request 7 months ago

    approved this merge request

  • Dan Jones @danjon mentioned in commit c37ec78c 7 months ago

    mentioned in commit c37ec78c

  • Dan Jones @danjon merged 7 months ago

    merged

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
Compare
  • version 5
    1d51a7b2
    7 months ago

  • version 4
    85aec3d0
    7 months ago

  • version 3
    50ada7fd
    7 months ago

  • version 2
    4c46abdb
    7 months ago

  • version 1
    a1880a9e
    7 months ago

  • 67-mas-dt (base)

and
  • latest version
    6901b7d7
    7 commits, 7 months ago

  • version 5
    1d51a7b2
    6 commits, 7 months ago

  • version 4
    85aec3d0
    4 commits, 7 months ago

  • version 3
    50ada7fd
    3 commits, 7 months ago

  • version 2
    4c46abdb
    2 commits, 7 months ago

  • version 1
    a1880a9e
    1 commit, 7 months ago

2 files
+ 3
- 4
Show latest version
    File browser
    Compare changes
for‎mats‎
platform_‎status.py‎ +1 -2
waypoi‎nts.py‎ +2 -2
formats/platform_status.py
+ 1
- 2
  • View file @ 85aec3d0

  • Edit in single-file editor

  • Edit in Web IDE


Files with large changes are collapsed by default.

Show all unchanged lines Show 20 lines
platform_status_core_fields_schema = {
"type": "object",
"properties": {
},
"properties": {},
}
platform_status_schema = {
Show 20 lines Show all unchanged lines
formats/waypoints.py
+ 2
- 2
  • View file @ 85aec3d0

  • Edit in single-file editor

  • Edit in Web IDE


Files with large changes are collapsed by default.

Show all unchanged lines Show 20 lines
"example": "2022-12-21T00:00:00Z",
},
"waypoints": {
"type": "array",
"type": "array",
"items": waypoint_schema,
}
},
},
"required": [
"message_type",
Show 20 lines Show all unchanged lines
Assignee
Dan Jones's avatar
Dan Jones
@danjon
Assign to
Reviewer
Trishna Saeharaseelan's avatar
@trishna
Request review from
CB-2024W37
Milestone
CB-2024W37 (Past due)
Assign milestone
None
Time tracking
No estimate or time spent
2
Labels
Partner::NOC Project::MAS-DT
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
3
3 participants
user avatar
user avatar
user avatar
Reference: communications-backbone-system/backbone-message-format!49
Source branch: 78-update-platform-status-to-accommodate-simulated-wpts

    0 pending comments