GitLab

Closes #19 (closed)

changed milestone to %SoAR-2023W09

added Partner::NOC Status::Sprint Backlog Weight::2 bug labels

added 1 commit

• 66d3ad4d - fix: examples and update destination topics

Compare with previous version

added 1 commit

• 6dd0ac37 - refactor: regenerate swagger json

Compare with previous version

marked this merge request as ready

requested review from @danjon

First failure: autonomy_engine_adapter/planning_configuration.json

• Fails with swagger-model-validator
• Fails with additionalProperties:false rule removed
• Passes with json-schema-remote validator

Same ecosub_adapter/observation.json

Same ecosub_adapter/mission_plan.json

Hmm - just made a message deliberately invalid and ran it through json-schema-remote and it returned valid:true not sure that's the answer.

I'm coming back to the conclusion that we should change the messages (and/or the schema). So far the validator I'm using in the JS adapter (swagger-model-validator) is more strict that the python equivalent but I think it's more correct. For example it can't validate this schema property:

"region_surveyed": {
    "description": "Region surveyed by given platform. GEOJSON",
    "example": ""
}

because there's nothing to explain what region_surveyed should look like.

So far the other JS validators I've tested pass the messages but they also pass things that are definitely invalid. I can't find another JS validator that does the job better.

Not an error but the destination should always be in reference to the platform and send|receive is in defined in relation to the platform so you send to the platform and receive from the platform.

Destination is probably a misleading term. You don't send things to the autonomy engine. You send things with a topic the autonomy engine is interested in.

So the topic for an observation from ecosub-1 would be soar.planet-ocean.ecosub.ecosub-1.receive.observation the autonomy engine receives it because it has a subscription to something like soar.*.*.*.receive.*

added 5 commits

• 02a35ba9 - test: js validation of examples and schema
• 9ee9c579 - fix: update publish topics
• 73c223ac - fix: blacken
• 3ca5573a - fix: correct typo in example message topic
• c7e310ae - Merge branch 'validate-example-messages' into '19-refactor-tests'

Compare with previous version

approved this merge request

merged

mentioned in commit ab272781